Simplify the color generation for cost vs run plots. #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was a static mapping of controller type to color. That doesn't jive well with supporting third party controllers, since there's no way to know how many there are. Now colors for cost vs run plots are generated on the fly based on how many different colors are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was a static mapping of controller type to color. That doesn't jive well with supporting third party controllers, since there's no way to know how many there are. Now colors for cost vs run plots are generated on the fly based on how many different colors are needed.
This PR implements the idea initially suggested in #144.
Changes proposed in this pull request:
ControllerVisualizer.plot_cost_vs_run()are now generated on-the-fly based on how many distinct colors are needed.