Fix show_all_default_visualizations() for random and Nelder-Mead learners.
#140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead learners. To do this, empty visualizer classes were created for those two learners. These visualization classes don't currently generate any plots, but they could in the future.
…MeadVisualizer` `create_visualization()` methods are called, as they don't currently actually generate any plots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds empty visualizer classes for those two learners. These visualization classes don't currently generate any plots, but they could in the future. Previously,
create_learner_visualizer_from_archive()would raise aValueErrorbecause these learners didn't have an associated visualizer class.Changes proposed in this pull request:
show_all_default_visualizations()for random and Nelder-Mead learners.