Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update release pipeline #469

Merged
merged 1 commit into from
Nov 16, 2024
Merged

update release pipeline #469

merged 1 commit into from
Nov 16, 2024

Conversation

michaelfeil
Copy link
Owner

Related Issue

Checklist

  • I have read the CONTRIBUTING guidelines.
  • I have added tests to cover my changes.
  • I have updated the documentation (docs folder) accordingly.

Additional Notes

Add any other context about the PR here.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates Poetry version from 1.7.1 to 1.8.4 across all workflow files and Dockerfiles, while also making significant changes to the release pipeline structure and dependency management.

  • Introduces requirements_install_from_poetry.sh script for more flexible dependency installation in Dockerfiles
  • Updates CUDA version to 12.3.2 with cuDNN 9 and adds TensorRT 10.3.0 in TRT ONNX Dockerfile
  • Adds matrix strategy in pypi_release.yaml to handle multiple packages (infinity_emb and client_infinity)
  • Removes docker-container-push-onnx-trt job due to GitHub Actions container size limitations
  • Adds modal-deploy job dependent on publish-to-pypi completion in release pipeline

13 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Comment on lines +13 to +17
strategy:
matrix:
package:
- workdir: "libs/infinity_emb"
- workdir: "libs/client_infinity"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Matrix strategy needs fail-fast configuration to control behavior when one package fails to publish

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.57%. Comparing base (8ac0b3c) to head (c353d8b).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   79.51%   79.57%   +0.05%     
==========================================
  Files          41       41              
  Lines        3417     3417              
==========================================
+ Hits         2717     2719       +2     
+ Misses        700      698       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelfeil michaelfeil merged commit 83740ce into main Nov 16, 2024
36 checks passed
@michaelfeil michaelfeil deleted the update-release-pipeline branch November 16, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants