Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vision unpin #279

Merged
merged 1 commit into from
Jun 22, 2024
Merged

fix: vision unpin #279

merged 1 commit into from
Jun 22, 2024

Conversation

michaelfeil
Copy link
Owner

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Updated coverage command in Makefile to use 'coverage run'
  • Added iterator method and updated rerank method in SyncEngineArray
  • Modified _normalize_cpu to return numpy arrays
  • Updated Python version compatibility in pyproject.toml to <4

4 file(s) reviewed, no comment(s)

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.87%. Comparing base (22c270c) to head (4bd0e89).

Files Patch % Lines
libs/infinity_emb/infinity_emb/sync_engine.py 75.00% 1 Missing ⚠️
...mb/infinity_emb/transformer/vision/torch_vision.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (22c270c) and HEAD (4bd0e89). Click for more details.

HEAD has 6 uploads less than BASE | Flag | BASE (22c270c) | HEAD (4bd0e89) | |------|------|------| ||8|2|
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
- Coverage   77.48%   68.87%   -8.61%     
==========================================
  Files          35       35              
  Lines        2500     2503       +3     
==========================================
- Hits         1937     1724     -213     
- Misses        563      779     +216     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelfeil michaelfeil merged commit 473832b into main Jun 22, 2024
14 of 34 checks passed
@michaelfeil michaelfeil deleted the infinity-unpin-vision-fixes branch June 22, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants