Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sync array #277

Merged
merged 2 commits into from
Jun 21, 2024
Merged

add sync array #277

merged 2 commits into from
Jun 21, 2024

Conversation

michaelfeil
Copy link
Owner

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Added SyncEngineArray import and re-export in __init__.py
  • Added synchronous methods to AsyncEngineArray in engine.py
  • Introduced sync_engine.py for synchronous interface
  • Added unit tests for SyncEngineArray in test_sync_engine.py

4 file(s) reviewed, 1 comment(s)

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 85.86957% with 13 lines in your changes missing coverage. Please review.

Project coverage is 77.48%. Comparing base (56f39c6) to head (ec0ee68).

Files Patch % Lines
libs/infinity_emb/infinity_emb/sync_engine.py 89.47% 8 Missing ⚠️
libs/infinity_emb/infinity_emb/engine.py 66.66% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   77.16%   77.48%   +0.31%     
==========================================
  Files          34       35       +1     
  Lines        2409     2500      +91     
==========================================
+ Hits         1859     1937      +78     
- Misses        550      563      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelfeil michaelfeil enabled auto-merge (rebase) June 21, 2024 22:10
@michaelfeil michaelfeil merged commit 22c270c into main Jun 21, 2024
34 checks passed
@michaelfeil michaelfeil deleted the sync-engine-array branch June 21, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants