Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2967 emit icclear on clearall on multiselect #3058

Open
wants to merge 3 commits into
base: v3.0.0/develop
Choose a base branch
from

Conversation

MI6-286
Copy link
Contributor

@MI6-286 MI6-286 commented Jan 17, 2025

Summary of the changes

Added icClear event to clear all button of multiselect. Edited Cypress test to include a check for icClear on click of clear all, and updated storybook examples.

Related issue

#2967

Checklist

General

  • Changes to docs package checked and committed.
  • All acceptance criteria reviewed and met.

Testing

  • Relevant unit tests and visual regression tests added.
  • Visual testing against Figma component specification completed.
  • Playground stories in React Storybook up to date, with any prop changes and additions addressed.
  • Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.
  • Manual keyboard testing for keyboard controls and logical focus order.
  • Correct roles used and ARIA attributes used correctly where required.
  • Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

  • Page can be zoomed to 400% with no loss of content.
  • Screen magnifier used with no issues.
  • Text resized to 200% with no loss of content.
  • Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

  • Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • Windows High Contrast mode tested with no loss of content.
  • System light and dark mode tested with no loss of content.
  • Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

  • Min/max content examples tested with no loss of content or overflow.
  • All prop combinations work without issue.
  • Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
  • Controlled and uncontrolled input components tested.
  • Props/slots can be updated after initial render.

Copy link
Contributor

@MI6-286 MI6-286 force-pushed the 2967-emit-icclear-on-clearall-on-multiselect branch from 5b4de48 to d43a010 Compare January 17, 2025 15:33
…ing storybook

Adding Cypress test to check for IcClear event and updating default multi-select storybook example
update docs with icClear event on clear all click
…ti-select

Adding icClear event to clear all button of multi-select and updating default multi-select storybook
@MI6-286 MI6-286 force-pushed the 2967-emit-icclear-on-clearall-on-multiselect branch from d43a010 to d8f4ce2 Compare January 20, 2025 12:02
@MI6-286 MI6-286 marked this pull request as ready for review January 20, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant