Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1800 Hide the compliance section of the IcFooter when there is no logo, caption or copyright information #3005

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

dn55533
Copy link
Contributor

@dn55533 dn55533 commented Jan 10, 2025

Summary of the changes

This change hides the compliance section of the IcFooter when there is no logo, caption or copyright information.

Previously, this section was being rendered even if all of these were turned off, resulting the empty compliance section being displayed.

Related issue

#1800

Checklist

General

  • Changes to docs package checked and committed.
  • All acceptance criteria reviewed and met.

Testing

  • Relevant unit tests and visual regression tests added.
  • Visual testing against Figma component specification completed.
  • Playground stories in React Storybook up to date, with any prop changes and additions addressed.
  • Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.
  • Manual keyboard testing for keyboard controls and logical focus order.
  • Correct roles used and ARIA attributes used correctly where required.
  • Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

  • Page can be zoomed to 400% with no loss of content.
  • Screen magnifier used with no issues.
  • Text resized to 200% with no loss of content.
  • Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

  • Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • Windows High Contrast mode tested with no loss of content.
  • System light and dark mode tested with no loss of content.
  • Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

  • Min/max content examples tested with no loss of content or overflow.
  • All prop combinations work without issue.
  • Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
  • Controlled and uncontrolled input components tested.
  • Props/slots can be updated after initial render.

@GCHQ-Developer-112
Copy link
Contributor

Thank you for raising a PR on this! It would be good to have a Cypress visual regression test for this change

gd2910

This comment was marked as outdated.

Copy link
Contributor

@gd2910 gd2910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also include a snapshot unit test to maintain testing code coverage.

@dn55533 dn55533 force-pushed the fix/1800-when-copyright-is-set-to-false-an-empty-section-remains branch 3 times, most recently from a159e7e to 97f0a53 Compare January 16, 2025 12:53
@dn55533 dn55533 force-pushed the fix/1800-when-copyright-is-set-to-false-an-empty-section-remains branch from 97f0a53 to ff1e609 Compare January 17, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants