Invoke GetHighlights on subject buffer #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll defer to you on this one TBH, I'm still not familiar with how things work when there are multiple buffers :) Just LMK if it's ready to merge. |
KirillOsenkov
force-pushed
the
dev/kirillo/hrProjection
branch
from
a6d3079
to
567277a
Compare
|
I've rebased on latest. I've been dogfooding this change and it does fix the exception I've been seeing in diff view. Let's merge this and I can send additional PRs later as we go. |
KirillOsenkov
force-pushed
the
dev/kirillo/hrProjection
branch
from
567277a
to
6a55270
Compare
|
Happy to walk you through projection buffers whenever you want. Mostly relevant for diff (viewing or editing pending changes in a .csproj file). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows the general approach, however more work is needed when caret moves or text changes, to find the right snapshot of content type xml, and use that, instead of using the top buffer snapshot.