More robust header parsing #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed htonl dependency for open_write, quick n' dirty for tests and open_read
We now skip over unrecognized subchunks between fmt and data, but also between WAVE and fmt
…the data subchunk size declared in header
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote wav header parsing with the following advantages:
htonl()-- no need for external dependency, since code is now endianess-agnostic by reading byte-by-byteTinyWav now supports (and tests!) the following scenarios:
fmtanddataWAVEandfmt(rare, but it does happen...)These kind of headers are now parsed correctly.
Furthermore,
tinywav_read_fwill not allow to read further than the data subchunk size declared in header. Some wave files have additionalLISTchunks after the audio subchunk (e.g. generated by Reaper)