Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUIC matcher: curl compatibility and misc changes #263

Merged
merged 6 commits into from
Nov 2, 2024
Merged

QUIC matcher: curl compatibility and misc changes #263

merged 6 commits into from
Nov 2, 2024

Conversation

vnxme
Copy link
Collaborator

@vnxme vnxme commented Nov 2, 2024 •
edited
Loading

Following #262, I've identified that curl (unlike quicreach):

  • doesn't like/support ED25519 as a private key algorithm for a QUIC server certificate, but works fine with RSA and ECDSA;
  • doesn't receive correct responses from quic-go when the latter has a tls.Certificate with the Leaf field set and the Certificate field unset (when it is properly filled, the Leaf field is parsed automatically).

I've made a few more minor updates to the code and added extra tests to address curl compatibility.

mholt
mholt approved these changes Nov 2, 2024
View reviewed changes
Copy link
Owner

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. LGTM. Thanks a bunch!

@mholt mholt merged commit d8ba3fb into mholt:master Nov 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vnxme @mholt