-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop the loop when listener is closed #261
Conversation
Thanks Weidi! As usual you beat me to it. Do you know why this is needed though? Like why doesn't closing the listener bump out of the Accept loop? (Only when SSH connections are active...?) |
The listener wrapper is used in my own listener plugin, which is only used on linux. I guess because listeners on linux use port reuse by default, the error there was temporary. On other platforms, it's implemented via a deadline, which is temporary. |
It's not ssh though, the listener loop is still running, and the error here is never received, because this listener silently discard it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Just one idea to make things a bit simpler...
Should I test this again or is it ready? |
I'll circle back to this soon! Been busy |
@mholt No stress just wanted to ask <3 |
CI failure seems unrelated |
Fix 258.