Rename ip handler into remote_ip #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Looks good. Thanks for bringing this to my attention!
@francislavoie what do you think?
|
Seems fine to me. One minor concern is we don't really have release notes or changelogs so it might be a surprise for some to have to fix it. But I agree with doing it now for consistency. |
This was referenced Jul 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #217, this is a breaking change that renames
iphandler intoremote_ip.Consequently, we will have consistently named
remote_ipmatchers at layer4, tls and http levels.If this PR gets merged first, I will rebase #217 on it. Otherwise this PR will have to be rebased.