This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Add Read and Write methods to Archiver interface that accept io.Reader/io.Writer. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r/io.Writer. 1. Adds methods to interface. 2. Implement methods for each format. 3. Reimplement Make/Open so that code is shared.
![gopherci[bot]](https://avatars.githubusercontent.com/in/889?s=60&v=4){kind=small}
| // Write writes an archive to a Writer. | ||
| Write(output io.Writer, sources []string) error | ||
| // Read reads an archive from a Reader. | ||
| Read(input io.Reader, destination string) error |
There was a problem hiding this comment.
apicompat: breaking change members added
|
|
||
| // symmetricTest compares the contents of a destination directory to the contents | ||
| // of the test corpus and tests that they are equal. | ||
| func symmetricTest(t *testing.T, name, dest string) { |
There was a problem hiding this comment.
Fixed by next commit.
… os.RemoveAll I accidentally left commented out.
| Open(source, destination string) error | ||
| // Write writes an archive to a Writer. | ||
| Write(output io.Writer, sources []string) error |
There was a problem hiding this comment.
apicompat: breaking change members added
mholt
approved these changes
Oct 12, 2017
This was referenced Jun 21, 2018
|
this broke multipart rar files ... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This intended to implement a solution to issue #20.