Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commitlint): ignore "wip" messages in commitlint #209

Conversation

mheob
Copy link
Owner

@mheob mheob commented Oct 14, 2024

Summary by CodeRabbit

  • New Features

    • Commit linting now ignores "wip" messages, allowing work-in-progress commits without errors.
    • Enhanced integration with SonarLint for improved code quality checks.
  • Configuration Changes

    • Adjusted code formatting and linting settings to prioritize ESLint over Prettier.

Also add SonarLint project configuration
@mheob mheob added enhancement New feature or request commitlint Belongs to commitlint config labels Oct 14, 2024
Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: 8461ded

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@mheob/commitlint-config Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eslint-config ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 0:23am

Copy link

coderabbitai bot commented Oct 14, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce a minor update to the @mheob/commitlint-config package, allowing commit messages that contain "wip" (work in progress) to bypass linting errors. This is achieved by adding an ignores property in the configuration. Additionally, modifications to the .vscode/settings.json file adjust code formatting and linting settings, including disabling Prettier and configuring ESLint to fix issues on save. A new configuration for SonarLint is also added to facilitate integration for code quality checks.

Changes

File Path Change Summary
packages/commitlint-config/src/index.ts Added ignores: [message => /wip/i.test(message)] to ignore "wip" messages in commitlint.
.vscode/settings.json Modified settings: disabled Prettier, set editor.formatOnSave to false, configured ESLint, and added SonarLint connection settings.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant CommitLint
    participant ESLint
    participant SonarLint

    Developer->>CommitLint: Commit message (e.g., "wip: work in progress")
    CommitLint-->>Developer: Ignore commit (no linting error)
    
    Developer->>ESLint: Save file
    ESLint-->>Developer: Fix issues on save

    Developer->>SonarLint: Analyze code
    SonarLint-->>Developer: Provide code quality feedback
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

Failed to generate code suggestions for PR

…mmitlint-Also-add-SonarLint-project-configuration
Copy link

sonarcloud bot commented Oct 14, 2024

@kodiakhq kodiakhq bot merged commit 05329c9 into main Oct 14, 2024
9 checks passed
@kodiakhq kodiakhq bot deleted the feat(commitlint)-ignore-"wip"-messages-in-commitlint-Also-add-SonarLint-project-configuration branch October 14, 2024 12:23
mheob added a commit that referenced this pull request Oct 14, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @mheob/[email protected]

### Minor Changes

- [#209](#209)
([@mheob](https://github.com/mheob)): ignore "wip" messages in
commitlint

### Patch Changes

- [#210](#210)
([@mheob](https://github.com/mheob)): update dependencies

## @mheob/[email protected]

### Minor Changes

- [#210](#210)
([@mheob](https://github.com/mheob)): update dependencies

### Patch Changes

- [#205](#205)
([@renovate](https://github.com/apps/renovate)): update all non-major
dependencies

- [#202](#202)
([@renovate](https://github.com/apps/renovate)): update all non-major
dependencies

## @mheob/[email protected]

### Patch Changes

- [#210](#210)
([@mheob](https://github.com/mheob)): update dependencies

Co-authored-by: Alex Böhm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commitlint Belongs to commitlint config enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant