Clarify README about unique expiration #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhenrixon
added a commit
that referenced
this pull request
May 11, 2014
Clarify README about unique expiration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make sure I understood how long the uniqueness of a job lasts and, if my observation is correct, update the README accordingly.
I'm confident that the job will be unique for the shorter of the seconds configured or seconds for the job to complete. See: https://github.com/mhenrixon/sidekiq-unique-jobs/blob/master/lib/sidekiq-unique-jobs/middleware/client/unique_jobs.rb#L47
I'm less confident about my observation with Sidekiq versions before 3.0, but I'm pretty sure it's the reason why my long running jobs do not remain unique. See: sidekiq/sidekiq#1508 (comment) and https://github.com/mperham/sidekiq/blob/20b7a4fe47585ce9c43981305d146bd087540bbf/lib/sidekiq/web_helpers.rb#L50-L83
Thanks!