You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Version: sidekiq-unique-jobs (7.1.27)
As per the readme, trying to validate options.
#app/workers/bad_worker.rbclassBadWorkerincludeSidekiq::Jobsidekiq_optionslock: :while_executing,on_conflict: :replaceend#spec/workers/bad_worker_spec.rbrequire"sidekiq_unique_jobs/rspec/matchers"# require "sidekiq_unique_jobs/testing" -- using this results in a different errorRSpec.describeOutboxMessageEvents::BadWorkerdospecify{expect(described_class).tohave_valid_sidekiq_options}end
Expected behavior
Expected BadWorker to have valid sidekiq options but found the following problems:
on_server_conflict: :replace is incompatible with the server process
Current behavior
BadWorker is expected to have valid sidekiq options
Failure/Error: specify { expect(described_class).to have_valid_sidekiq_options }
NameError:
uninitialized constant SidekiqUniqueJobs::Lock::BaseLock::Validator
# ./spec/workers/bad_worker_spec.rb:4:in `block (2 levels) in <top (required)>'
# -e:1:in `<main>'
I ran into mhenrixon#741 pretty quickly when bringing this fantastic gem into a project.
It seems that the testing instructions are out of date. The "testing" lib does everything you need for RSpec, and includes necessary files.
I ran into a known issue[1] when trying to bring this gem into my project.
It turns out the instructions were just out of date. If you merely include the RSpec
file it misses other necessary requires. The noted file does everything you need
regardless of testing framework.
1. mhenrixon#741
Describe the bug
Version:
sidekiq-unique-jobs (7.1.27)
As per the readme, trying to validate options.
Expected behavior
Current behavior
Worker class
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: