Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loop in ruby reaper #515

Closed
markiz opened this issue Jun 11, 2020 · 3 comments · Fixed by #516
Closed

Infinite loop in ruby reaper #515

markiz opened this issue Jun 11, 2020 · 3 comments · Fixed by #516
Assignees
@mhenrixon
Labels
bug v7.x

Comments

@markiz
Copy link

markiz commented Jun 11, 2020

Describe the bug
https://github.com/mhenrixon/sidekiq-unique-jobs/blob/master/lib/sidekiq_unique_jobs/orphans/ruby_reaper.rb#L154-L165
This loop does not have an exit point.

Expected behavior
Reaper can finish.

Current behavior
Reaper loops indefinitely and is killed by timeout
@mhenrixon mhenrixon self-assigned this Jun 11, 2020
mhenrixon added a commit that referenced this issue Jun 11, 2020
@mhenrixon
Don't loop indefinitely
7fd1927 
Close #515
@mhenrixon mhenrixon mentioned this issue Jun 11, 2020
Merged
mhenrixon added a commit that referenced this issue Jun 12, 2020
@mhenrixon
Prevent indefinitely looping entries (#516)
168bb25 
* Don't loop indefinitely

Close #515

* Mandatory rubocop commit

* Adjust to new Redis API

* Mandatory rubocop commit

* Bump appraisals

* Support both older and newer redis gem API

* Mandatory rubocop commit

* Reek

* Shorten commands

* Fix ruby 2.7 warnings
@mhenrixon
Copy link
Owner

Fixed and released as v7.0.0.beta21 @markiz, thanks for the report!

@markiz
Copy link
Author

markiz commented Jun 12, 2020 •
edited
Loading

@mhenrixon FYI: this also (seemingly) fixes thread leaking, which occurs when ConcurrentRuby::TimedTask times out.

image

Relevant issue here: ruby-concurrency/concurrent-ruby#639

@mhenrixon
Copy link
Owner

Jesus, had no idea! I'll have a look at the related concurrent-ruby issue tonight! Thanks a bunch for sharing that @markiz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhenrixon mhenrixon

Labels
bug v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent indefinitely looping entries mhenrixon/sidekiq-unique-jobs
2 participants
@markiz @mhenrixon