Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled workers #1

Closed
axsuul opened this issue Aug 9, 2012 · 6 comments
Closed

Scheduled workers #1

axsuul opened this issue Aug 9, 2012 · 6 comments

Comments

@axsuul
Copy link

axsuul commented Aug 9, 2012

Was this intended to work with workers that need to be scheduled?

@mhenrixon
Copy link
Owner

I actually never considered that but I will have a look and add it if needed. We really need the scheduled jobs to be unique as well so I'll get back to you on that.

@axsuul
Copy link
Author

axsuul commented Aug 19, 2012

Any updates on this?

@mhenrixon
Copy link
Owner

Not yet, I've done some investigation and it looks like the recent sidekiq changes broke any unique possibility since every job is now unique. See sidekiq/sidekiq#359 for more information.

@mhenrixon
Copy link
Owner

It's currently not working very well if you schedule a job further than 3600 seconds into the future, I'll make the key expire when the unique job is scheduled for if it's a scheduled job.

@mhenrixon
Copy link
Owner

f89097e should fix this issue!

@axsuul
Copy link
Author

axsuul commented Aug 20, 2012

Awesome! I plan to test this out either today or tomorrow

mhenrixon pushed a commit that referenced this issue Jun 22, 2015
Don't remove unique lock on shutdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants