feat: look up a hash by version #90
Conversation
Fixes mheap#83 Signed-off-by: Lucas Gonze <[email protected]>
| .parse(process.argv); | ||
|
|
||
| const filename = program.args[0]; | ||
| const filename = program.args[0]; |
There was a problem hiding this comment.
Please run npm run lint-fix to ensure that formatting is correct
| [onlyOwner,onlyRepo] = parts; | ||
|
|
||
| parts = onlyRepo.split("@"); | ||
| if( 2 == parts.length ){ |
There was a problem hiding this comment.
parts.length == 2 here please, we don't use yoda conditions anywhere else
| } | ||
| [onlyOwner,onlyRepo] = parts; | ||
|
|
||
| parts = onlyRepo.split("@"); |
There was a problem hiding this comment.
Variable shadowing here. Could we use a more descriptive (and different) variable name?
| debug = log.extend("find-ref-on-github"); | ||
| return new Promise(async function (resolve, reject) { | ||
| const owner = action.owner; | ||
| const repo = action.repo; | ||
| const pinned = action.pinnedVersion; | ||
| const pinned = onlyVersion ? onlyVersion : action.pinnedVersion; |
There was a problem hiding this comment.
Could you add a test in findRefOnGitHub.test.js that covers this change?
| @@ -33,9 +36,24 @@ module.exports = async function ( | |||
| continue; | |||
| } | |||
|
|
|||
| if (onlyOwner && actions[i].owner !== onlyOwner ){ | |||
There was a problem hiding this comment.
Please extract this in to another file (e.g. checkSelectOnly.js) and write unit tests.
Example module: https://github.com/mheap/pin-github-action/blob/main/checkAllowedRepos.js
Example tests: https://github.com/mheap/pin-github-action/blob/main/checkIgnoredRepos.test.js
| continue; | ||
| } | ||
|
|
||
| if (onlyRepo && onlyRepo !== "*" && actions[i].repo !== onlyRepo ){ |
There was a problem hiding this comment.
Rather than checking * explicitly, use matcher like the existing functionality
|
@lucasgonze Added a few comments. Please also update the README with usage instructions |
|
FYI I have not forgotten this. I have made progress but am mainly on vacation so don't anticipate finishing until after I get back in 2-3 weeks. |
Fixes #83
Signed-off-by: Lucas Gonze [email protected]