Fix ResourceWarning from unclosed detached data NRRD files #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of now, the warnings are helpful in fixing potential bugs or future issues in the library. However, this filter may need to be updated in the future to ignore issues that are not relevant.
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
+ Coverage 99.17% 99.18% +<.01%
==========================================
Files 6 6
Lines 363 366 +3
Branches 117 117
==========================================
+ Hits 360 363 +3
Misses 1 1
Partials 2 2
Continue to review full report at Codecov.
|
addisonElliott
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable all warnings during tests to see additional problems in the code. The following warning appeared:
Problem resolved by closing the file handle before raising errors. The only time this issue occurs is when the data is detached from the header. The detached data filename is loaded using an
opencall without a "with" block.