Move CI to GitHub actions #116
Conversation
|
This has been tested and it is working in my fork: https://github.com/bernardopericacho/pynrrd/actions/runs/2304161140 |
.github/workflows/test.yml
Outdated
| jobs: | ||
| test: | ||
| name: test | ||
| runs-on: ubuntu-18.04 |
There was a problem hiding this comment.
using ubuntu-18.04 instead of ubuntu-latest so we can run tests over Python 3.4. This is a pure migration of what we already have in travis but we can discuss further if we should still be supporting versions that are deprecated (< 3.7)
There was a problem hiding this comment.
Great point. I'm fine dropping Python 3.4 support in testing. It's been EOL for quite awhile now.
Let's change to ubuntu-latest and use a newer Python version. Maybe 3.7 and 3.9 for testing?
There was a problem hiding this comment.
that sounds good to me, should I also drop support for 3.4, 3.5 and 3.6 in the setup.py as part of this PR?
There was a problem hiding this comment.
Yeah, that's probably a good plan.
|
🎉 This is wonderful! I have no objection to GitHub Actions. Seems to be the future now-a-days. As it stands now, the Travis deployment script doesn't work. I've been deploying manually via CLI, which is fine since it's not done often. I'm all for getting that back up and running via GitHub actions. For this PR, let's leave out the deployment part. We can address that in a separate PR. It should be pretty simple to setup and then @mhe will need to add a secret to the repository I believe. |
.github/workflows/test.yml
Outdated
| jobs: | ||
| test: | ||
| name: test | ||
| runs-on: ubuntu-18.04 |
There was a problem hiding this comment.
Great point. I'm fine dropping Python 3.4 support in testing. It's been EOL for quite awhile now.
Let's change to ubuntu-latest and use a newer Python version. Maybe 3.7 and 3.9 for testing?
.github/workflows/test.yml
Outdated
| jobs: | ||
| test: | ||
| name: test | ||
| runs-on: ubuntu-18.04 |
There was a problem hiding this comment.
that sounds good to me, should I also drop support for 3.4, 3.5 and 3.6 in the setup.py as part of this PR?
|
That's awesome, thanks! I'm all for it! |
Proposed changes:
@mhe @addisonElliott we will need to create another job or workflow for publishing the releases before we remove the travis.yml file completely