Fix issue with loading large files #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the error message that would popup before this fix: Size of the data does not equal to the product of all dimensions
Codecov Report
@@ Coverage Diff @@
## master #101 +/- ##
=======================================
Coverage 99.46% 99.46%
=======================================
Files 6 6
Lines 374 374
Branches 119 119
=======================================
Hits 372 372
Misses 1 1
Partials 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the error message that would popup before this fix:
Problem was that multiplying the dimensions together was overflowing the 32-bit result for larger than 4GB files.
Fixes #100