Skip to content

Commit

Permalink
test: disable fs watch tests for AIX
Browse files Browse the repository at this point in the history
fs watch currently needs special configuration on AIX and we
want to improve under nodejs#5085.
Tests are disabled so CI can be green and we can spot other
regressions until this work is complete.

test-async-wrap-check-providers does not aim to test fs watch
but part of the test uses it so that part has been skipped for
AIX
  • Loading branch information
mhdawson committed Feb 11, 2016
1 parent 2848f84 commit 408edcb
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 3 deletions.
7 changes: 7 additions & 0 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,10 @@ test-tick-processor : PASS,FLAKY
[$system==solaris] # Also applies to SmartOS

[$system==freebsd]

# fs-watch currently needs special configuration on AIX and we
# want to improve under https://github.com/nodejs/node/issues/5085.
# Tests are disabled so CI can be green and we can spot other
# regressions until this work is complete
[$system==aix]
test-fs-watch-enoent : FAIL, PASS
22 changes: 19 additions & 3 deletions test/parallel/test-async-wrap-check-providers.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,16 @@ let keyList = pkeys.slice();
// Drop NONE
keyList.splice(0, 1);

// fs-watch currently needs special configuration on AIX and we
// want to improve under https://github.com/nodejs/node/issues/5085.
// strip out fs watch related parts for now
if (common.isAix) {
for (var i = 0; i < keyList.length; i++) {
if ((keyList[i] === 'FSEVENTWRAP') || (keyList[i] === 'STATWATCHER')) {
keyList.splice(i, 1);
}
}
}

function init(id) {
keyList = keyList.filter((e) => e != pkeys[id]);
Expand All @@ -33,9 +43,15 @@ async_wrap.enable();
setTimeout(function() { });

fs.stat(__filename, noop);
fs.watchFile(__filename, noop);
fs.unwatchFile(__filename);
fs.watch(__filename).close();

if (!common.isAix) {
// fs-watch currently needs special configuration on AIX and we
// want to improve under https://github.com/nodejs/node/issues/5085.
// strip out fs watch related parts for now
fs.watchFile(__filename, noop);
fs.unwatchFile(__filename);
fs.watch(__filename).close();
}

dns.lookup('localhost', noop);
dns.lookupService('::', 0, noop);
Expand Down
6 changes: 6 additions & 0 deletions test/sequential/sequential.status
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,9 @@ test-vm-syntax-error-stderr : PASS,FLAKY

[$system==freebsd]

# fs-watch currently needs special configuration on AIX and we
# want to improve under https://github.com/nodejs/node/issues/5085.
# Tests are disabled so CI can be green and we can spot other
# regressions until this work is complete
[$system==aix]
test-fs-watch : FAIL, PASS

0 comments on commit 408edcb

Please sign in to comment.