Added Range to Unsignable Headers #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Added in 69922c9 I don't have CI setup for this yet (the tests rely on puppeteer) so I had to run Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developers using Cloudflare Workers (Service Workers running on our global edge network) rely on this library to sign requests to Amazon S3.
CDNs such as Cloudflare often manipulate or strip the Range Header to optimise/reduce the cost how content is pulled from S3. This behaviour is important because the Range header can take arbitrary, high-cardinality values. If CDNs don't do this then cache hit rates will be very poor leading to increased latency and cost fetching data directly from S3.
This pull request includes Range as an Unsignable Header so the signature can be used by a CDN to fetch the full object or normalised byte ranges, improving performance and reducing cost of serving content from S3.