Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set header Content-Length as a string #67

Closed
wants to merge 2 commits into from
Closed

Set header Content-Length as a string #67

wants to merge 2 commits into from

Conversation

DaniGuardiola
Copy link

The number format caused a problem on the node-vault module: hashicorp/vault#3763 (comment)

This should solve it, unless there's any reason to keep it as a number.

Copy link
Author

@DaniGuardiola DaniGuardiola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the code and it works just fine

@mhart
Copy link
Owner

mhart commented Jan 8, 2018

I think this is best done in the vault code (considering that they're the ones enforcing the schema) – that way it doesn't affect any existing users of aws4.

ie, do it just before here: https://github.com/DaniGuardiola/node-vault/blob/7525dc5a335d70be21e3cfd77becfc4bf9e9c94a/src/aws-auth.js#L56

@mhart mhart closed this Jan 8, 2018
@DaniGuardiola
Copy link
Author

@mhart

But doesn't the signature need the same header format? Just wondering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants