Vendor h2py to regenerate scintillacon.py #2429
Open
+1,392
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Nov 18, 2024
Comment on lines
+13
to
+14
| # PYTHON is set in make.py, defaulting to the one found on PATH | ||
| PYTHON = python |
There was a problem hiding this comment.
Avasam
commented
Nov 18, 2024
| @@ -453,7 +453,6 @@ def _build_scintilla(self): | |||
| assert os.path.isdir(build_temp), build_temp | |||
| makeargs.append("SUB_DIR_O=%s" % build_temp) | |||
| makeargs.append("SUB_DIR_BIN=%s" % build_temp) | |||
| makeargs.append("DIR_PYTHON=%s" % sys.prefix) | |||
There was a problem hiding this comment.
If you'd like to restore the functionality of regenerating scintillacon.py on every rebuild I can do it, I just need to add a line like
powershell -Command "(Get-Content '..\pywin\scintilla\scintillacon.py' | Where-Object { -not $$_.StartsWith('def ') }) | Set-Content '..\pywin\scintilla\scintillacon.py'" to the makefile because for some reason under this context h2py finds and adds more definitions, namely broken callables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h2py is no longer included in Python as of Python 3.9
Personally I'd rather this doesn't happen on every build, so I updated the make
alltarget to not include this script.SCN_CHECKBRACEandSC_FOLDLEVELBOXFOOTERFLAGgot removed in Scintilla 1.79Also in 1.21: