Add EnumDesktopWindows && stuff #2219
Conversation
win32/test/test_win32gui.py
Outdated
| self.assertRaises( | ||
| ValueError, win32gui.EnumWindows, self.enum_callback_exc, data | ||
| ) | ||
| if sys.version_info[:2] >= (3, 10): |
There was a problem hiding this comment.
I don't understand why this only works in 3.10 an up?
There was a problem hiding this comment.
Good thing you asked, it is just the float value. I return it from the callback and the problem arises when it's converted to long. https://docs.python.org/3/c-api/long.html#c.PyLong_AsLong.
|
Sorry for the inaction here, but it LGTM - can you please resolve the conflicts and update it? |
CHANGES.txt
Outdated
| @@ -160,6 +160,8 @@ Coming in build 307, as yet unreleased | |||
| * Remove outdated and unused remote feature (#2098, @Avasam) | |||
| * Migrated from `distutils` to `setuptools` (#2133, @Avasam) | |||
|
|
|||
| * Add EnumDesktopWindows (#2219, @CristiFati) | |||
There was a problem hiding this comment.
I don't think you meant to add this under adodbapi
There was a problem hiding this comment.
Thanks, it was automatically done by rebase.
What's the status of that - should it be updated or closed? |
After merging this, I will close it, as this one also contains it. |
To be merged AFTER #2189 (as this is branched from that one).
EnumDesktopWindows is the main thing, the rest is just a quick win with minimal code changes.