Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -apollo-mode which adds __typename on every GraphQL Object in query #65

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

baransu
Copy link
Contributor

@baransu baransu commented Dec 10, 2018

"Apollo mode" adds __typename on every GraphQL Object. It allows using reason-apollo cache more efficiently.
I'm not sure how properly test that but I've assumed that counting __typename occurences in nested query would do the job.

Should fix: #39

/cc @Gregoirevda

@baransu
Copy link
Contributor Author

baransu commented Jan 6, 2019

@mhallin What's required to have that merged?

@mhallin mhallin merged commit 0b1ce89 into mhallin:master Jan 17, 2019
@Gregoirevda
Copy link

Great work @baransu!! Has this been deployed @mhallin ?

@mhallin
Copy link
Owner

mhallin commented Feb 5, 2019

It's scheduled for the 0.2.9 release, but I'm having issues with the Windows CI so it's unfortunately going to be delayed.

@baransu baransu deleted the feature/apollo-mode branch April 3, 2019 22:09
ylecornec pushed a commit to o1-labs/graphql_ppx that referenced this pull request Jun 3, 2022
* ci: move pipeline to one file, add esy cache
* ci: fix yaml syntax error
* ci: fix typo
* ci: use different docker image
* ci: change pipeline triggers
* ci: change job names
* ci: update job names
* ci: update publish if
* ci: upload artifacts only on release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add __typename for apollo-client
3 participants