Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to support case when on first page and only one total pages #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

miseas
Copy link

@miseas miseas commented Apr 2, 2020

Refactor of function header_links to fix the case when the header link should not be created.
Case: On first page and total pages equal to 1 -> don't create a header link
Added test case.
Related issue: #69

@juanperi
Copy link

juanperi commented Jul 2, 2020

Hey, Any chance to get this one merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants