DesktopBrowser: add support for xdg-open directly #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desktop browse functionality is disabled (not sure why) when running in a flatpak sandbox. Most linux distributions should support using xdg-open directly.
|
I tried finding out why Desktop.Action.Browse isn't supported with awt inside the flatpak sandbox. As an alternative, executing xdg-open works inside the flatpak. What do you think about this approach in general? My other thoughts were to provide a "BrowserLauncher" interface with the following methods:
and interate through all the mechanisms (opposed to having the multiple try/catch blocks). Thoughts? |
mguessan
added a commit
that referenced
this pull request
Oct 24, 2018
git-svn-id: https://svn.code.sf.net/p/davmail/code/trunk@2763 3d1905a2-6b24-0410-a738-b14d5a86fcbd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
desktop browse functionality is disabled (not sure why) when running
in a flatpak sandbox.
Most linux distributions should support using xdg-open directly.