Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for retrieving user certificates #353

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on May 13, 2024

  1. Add support for retrieving user certificates

    It's possible to add a public S/MIME certificate for a user to the GAL. These
    are used when a user wants to encrypt a mail to another user, or validate their
    signature. The public certificate of the recipient is required. Being able to
    look them up rather than engage in a manual or offline synchornisation process
    makes this easier, as well as fetching updated certificates when they're
    changed.
    
    The bulk of this work was done by @krutelp in
    mguessan#98 I merely extended it to support the
    UserSMIMECertificate field in addition to the MSExchangeCertificate field.
    
    These are both part of the EWS Contact:
    https://learn.microsoft.com/en-us/dotnet/api/microsoft.exchange.webservices.data.contact?view=exchange-ews-api
    
    I tried to do it without using ContactDataShape.AllProperties but like @krutelp
    couldn't find a method that would return the certificates.
    
    I extended the ignored tags based on what was returned by our Microsoft365
    instance, but not all of the fields listed under the Contact type above.
    
    I slightly modified the original PR to use Dos line endings in
    ResolveNamesMethod.java so exact changes could be observed instead of the
    entire file being changed.
    
    I also added the keys to the contact in ExchangeSession.java as KEY1 and KEY2.
    
    Finally, I undid the small changes in LdapConnection.java to the isMatch()
    methods to have them take an ExchangeSession.Contact and put them back to
    Map<String, String>. This was mostly done to limit the changes in the patch to
    those necessary.
    singe committed May 13, 2024
    Configuration menu
    Copy the full SHA
    40bd483 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Resolving review from @krutelp

    singe committed May 20, 2024
    Configuration menu
    Copy the full SHA
    0aecd9e View commit details
    Browse the repository at this point in the history