-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #97, decode ordered containers with 'fromDistinctAscList' #101
Conversation
Actually I'm not sure how to explain the speedup seen for Would you mind running the benchmarks on your box, @mgsloan? |
# Use new container infrastructure to enable caching | ||
sudo: false | ||
# Use sudo-enabled environment to get 7.5GB of memory instead of 4. | ||
sudo: required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to have worked.
Here's an overview of the various Travis CI environments.
Not sure why the OS X jobs didn't error out too.
I've fixed the merge conflicts. |
LGTM, thanks! |
Performance differences:
Time:
Memory allocations:
Apparently this version of
pokeMap
/pokeOrdMap
is a bit faster too! It'd be interesting to see ifHashMap
can benefit too, but I haven't added a benchmark yet.