Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing multiple images, keys method and adding row height config #1

Merged
merged 1 commit into from
Dec 15, 2016

Conversation

stewartsims
Copy link

Hi! Fixed a couple issues here:

  • I noticed when using multiple images the first one was repeated: just a couple places where the index of the image was not being respected during iteration

  • Added the addition from another PR for specifying row height e.g.

ws['!rows'] = [
    {hpx:275},
    {hpx:100},
    {hpx:100}
];
  • I found the keys method threw an error in some situations when it was being passed a 'null' argument, just made it more defensive but possibly a symptom of a problem elsewhere in the code

Feel free to merge or not as you like, as we've discussed this project is not really being maintained but these changes along with your original ones might help someone else out there who needs this capability.

@mgreter mgreter merged commit 372c484 into mgreter:master Dec 15, 2016
@mgreter
Copy link
Owner

mgreter commented Dec 15, 2016

Merged! Thanks a lot!

@JohnRSim
Copy link

Any chance you could get these updates merged with sheetjs repo 🥇
It looks like it's back to being maintained and worked on 👍 with the 0.93 release just coming out a day ago. - looks like there were some conflicts with the initial merge attempts

@stewartsims stewartsims deleted the master branch June 25, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants