Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it should include common methods. #1197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wangzhihao
Copy link

The common methods should be to include instead of to exclude.
It must be careless to add the Not operator. This PR is to remove the Not operator.

@pedromarce pedromarce self-assigned this Feb 15, 2016
@bostrom
Copy link
Collaborator

bostrom commented Dec 25, 2016

@wangzhihao Please explain why we need this change and please also provide tests for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants