Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed git config paths #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kenmoini
Copy link

@kenmoini kenmoini commented Nov 6, 2019

--global refers to the WinRM user's home path, specifically setting the --system file path with -f is best

--global refers to the WinRM user's home path, specifically setting the --system file path with -f is best
@oatakan
Copy link
Collaborator

oatakan commented Nov 7, 2019

@kenmoini Thanks for submitting this PR. I'm not sure how this is improving or fixing an issue? I think the intention here is to define git configuration for a specific user and not system wide. I don't see how specifying C:\Windows directory would help. Please clarify. Thanks.

@kenmoini
Copy link
Author

kenmoini commented Nov 7, 2019

Oh hey, sorry, shoulda clarified better.

Running Ansible 2.9 on Ubuntu.

Would fail at windows-workstation : Copy .gitconfig to user directory as the 5 previous commands weren't being written to C:\Windows.gitconfig, where that step tries to copy from.

Verbosely stating the config file in the windows-workstation : allow insecure git repos for self signed certificates and the following set git * tasks allows the windows-workstation : copy .gitconfig to user directory task to pass.

I believe 2.9 caused a number of errors maybe, I had to specifically set the var for ansible_user to ec2-user when deploying the RHEL systems. Didn't get too deep to check for adding that variable switching based on deployment infrastructure targets.

@oatakan
Copy link
Collaborator

oatakan commented Nov 7, 2019

@kenmoini thanks for providing more context. let's keep this PR open for now until we can replicate the issue/fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants