removes duplicated utility function (#652)

mgechev · Mar 18, 2022 · 5ce2ff5 · 5ce2ff5
1 parent 61222a1
commit 5ce2ff5
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/rule/exported.go b/rule/exported.go
@@ -23,7 +23,7 @@ type ExportedRule struct {
 func (r *ExportedRule) Apply(file *lint.File, args lint.Arguments) []lint.Failure {
 	var failures []lint.Failure
 
-	if isTest(file) {
+	if file.IsTest() {
 		return failures
 	}
 

diff --git a/rule/package-comments.go b/rule/package-comments.go
@@ -20,7 +20,7 @@ type PackageCommentsRule struct{}
 func (r *PackageCommentsRule) Apply(file *lint.File, _ lint.Arguments) []lint.Failure {
 	var failures []lint.Failure
 
-	if isTest(file) {
+	if file.IsTest() {
 		return failures
 	}
 

diff --git a/rule/utils.go b/rule/utils.go
@@ -19,10 +19,6 @@ const styleGuideBase = "https://golang.org/wiki/CodeReviewComments"
 // If id == nil, the answer is false.
 func isBlank(id *ast.Ident) bool { return id != nil && id.Name == "_" }
 
-func isTest(f *lint.File) bool {
-	return strings.HasSuffix(f.Name, "_test.go")
-}
-
 var commonMethods = map[string]bool{
 	"Error":     true,
 	"Read":      true,