refactor: general refactor/fixes #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, what's the convention about |
|
Not a big fan of packages called utils in general. If the file grows too much, we should probably think of a better way to organize the helpers. |
mgechev
reviewed
Mar 26, 2019
test/contextualDecoratorRule.spec.ts
Outdated
| it('should succeed if a property is decorated with @ContentChild() decorator', () => { | ||
| const source = ` | ||
| const source = `Component |
There was a problem hiding this comment.
This doesn't feel right. How does typescript parses the file successfully?
There was a problem hiding this comment.
It was a bad copy and paste. Fixed.
…nforce file name casing
…interfaces/types names to Angular*
|
friendly bump :) |
|
@wKoza would you be able to help reviewing? I'm on the road for the next two weeks. |
|
@rafaelss95 , I'll take a look at this next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
getDecoratorName. Currently, it throws an error if you try to get a name of adecoratorthat isn't a call expression; (porting from refactor(rule): rework prefer-inline-decorator to accept options #794)assertMultipleAnnotatedhelper (Currently it doesn't work well as I mentioned in other issues/PRs);Booleanchecks to the utility functionisNotNullOrUndefined(I've added a mini explanation in that file);camelCase;variable-name;utils;Angular-*;