Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rule): 'contextual-decorator' - decorators with arguments, accessors and some missing decorators not being handled #798

Merged
merged 1 commit into from
May 1, 2019

Conversation

rafaelss95
Copy link
Collaborator

@rafaelss95 rafaelss95 commented Mar 24, 2019

This:

  • Fixes a bug introduced in the new version; (Currently it's not reporting failures if the decorator has arguments due to
    .map(x => x.replace(/[^a-zA-Z]/g, ''))
  • Reports failures for accessors with decorators (ex. @Input, @ViewChild);
  • Reports failures for parameter properties decorators (ex. @Attribute, @Host, etc...);

Fixes #776.

@rafaelss95
Copy link
Collaborator Author

rafaelss95 commented Mar 24, 2019

I've added the blocked label until the #797 gets in.

@rafaelss95 rafaelss95 marked this pull request as ready for review April 14, 2019 18:48

const {
metadata: { ruleName }
} = Rule;

describe(ruleName, () => {
describe.only(ruleName, () => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you drop the .only part

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

…ors and some missing decorators not being handled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contextual-decorator: fails for some cases
2 participants