Fixed a bug that can't open a fileDialog to import/export a SDK file throughout the GUI. #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When export/import_SDKs_action is triggered, it sends False by default to the method, which is why the path argument receives False. To avoid this behavior and ensure None is passed instead, I used a lambda function.
joji2468ng
changed the title
|
Hi @joji2468ng thanks for the PR! |
|
@joji2468ng I have copy/pasted the fix of this PR by hand. Since it couldn't merge because of the mistake with the other PR you sent here 😄 Thanks for the contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When export/import_SDKs_action is triggered, it sends False by default to the method, which is why the path argument receives False. The path argument needs to receive None to open a file dialog, To avoid this behavior and ensure None is passed instead, I used a lambda function.