RBF manager fix mirror pose issue. Also more robust mirror pose with …

…custom names

release/scripts/mgear/core/anim_utils.py

@@ -56,13 +56,21 @@ def isSideElement(name):
     Returns:
         bool
 
-    Deleted Parameters:
-        node: str
     """
+    # try first wiht side labels if is a node. This will fail with attrs
+    try:
+        if isinstance(name, str):
+            node = pm.PyNode(name)
+        if node.hasAttr("side_label"):
+            side = node.side_label.get()
+            if side in "LR":
+                return True
+    except pm.MayaNodeError:
+        pass
 
+    # old logic for back compatibility
     if "_L_" in name or "_R_" in name:
         return True
-
     nameParts = stripNamespace(name).split("|")[-1]
 
     for part in nameParts.split("_"):
@@ -132,6 +140,8 @@ def swapSideLabelNode(node):
     Returns:
         str
     """
+    if isinstance(node, str):
+        node = pm.PyNode(node)
 
     # first check default swapSideLabel. For defaul Shifter naming system
     name = node.stripNamespace()
@@ -1257,7 +1267,7 @@ def spine_FKToIK(fkControls, ikControls, matchMatrix_dict=None):
 ##################################################
 
 
-def getMirrorTarget(nameSpace, node):
+def getMirrorTarget(nameSpace=None, node=None):
     """Find target control to apply mirroring.
 
     Args:
@@ -1267,11 +1277,18 @@ def getMirrorTarget(nameSpace, node):
     Returns:
         PyNode: Mirror target
     """
+    if not node:
+        return
+    if isinstance(node, str):
+        node = pm.PyNode(node)
 
     if isSideElement(node.name()):
         nameParts = stripNamespace(node.name()).split("|")[-1]
-        nameParts = swapSideLabel(nameParts)
-        nameTarget = ":".join([nameSpace, nameParts])
+        nameParts = swapSideLabelNode(nameParts)
+        if nameSpace:
+            nameTarget = ":".join([nameSpace, nameParts])
+        else:
+            nameTarget = nameParts
         return getNode(nameTarget)
     else:
         # Center controls mirror onto self
@@ -1409,48 +1426,6 @@ def calculateMirrorData(srcNode, targetNode, flip=False):
         )
     return results
 
-
-def calculateMirrorDataRBF(srcNode, targetNode):
-    """Calculate the mirror data
-
-    Args:
-        srcNode (str): The source Node
-        targetNode ([dict[str]]): Target node
-        flip (bool, optional): flip option
-
-    Returns:
-        [{"target": node, "attr": at, "val": flipVal}]
-    """
-    results = []
-
-    # mirror attribute of source
-    for attrName in listAttrForMirror(srcNode):
-
-        # Apply "Invert Mirror" check boxes
-        invCheckName = getInvertCheckButtonAttrName(attrName)
-        if not pm.attributeQuery(
-            invCheckName, node=srcNode, shortName=True, exists=True
-        ):
-            inv = -1
-        else:
-            inv = 1
-
-        # if attr name is side specified, record inverted attr name
-        if isSideElement(attrName):
-            invAttrName = swapSideLabel(attrName)
-        else:
-            invAttrName = attrName
-
-        results.append(
-            {
-                "target": targetNode,
-                "attr": invAttrName,
-                "val": srcNode.attr(attrName).get() * inv,
-            }
-        )
-    return results
-
-
 def mirrorPoseOld(flip=False, nodes=False):
     """Deprecated: Mirror pose
 

release/scripts/mgear/rigbits/rbf_manager2/rbf_manager_ui.py

@@ -73,6 +73,7 @@
 from mgear.core import pyqt
 import mgear.core.string as mString
 from mgear.core import anim_utils
+from mgear.core import attribute
 from mgear.vendor.Qt import QtWidgets, QtCore, QtCompat, QtGui
 from maya.app.general.mayaMixin import MayaQWidgetDockableMixin
 from mgear.rigbits.six import PY2
@@ -208,6 +209,7 @@ def show(dockable=True, newSceneCallBack=True, *args):
     # Create the UI
     RBF_UI = RBFManagerUI(newSceneCallBack=newSceneCallBack)
     RBF_UI.initializePoseControlWidgets()
+    RBF_UI.reevalluateAllNodes()
 
     # Check if we've saved a size previously and set it
     if mc.optionVar(exists='RBF_UI_width') and mc.optionVar(exists='RBF_UI_height'):
@@ -1543,9 +1545,11 @@ def mirrorSetup(self):
         driverControl = aRbfNode.getDriverControlAttr()
         driverControl = pm.PyNode(driverControl)
         # Sanity check: make sure mirror attributes are set up properly
+        driven_ctl = []
         for targetInfo in setupTargetInfo_dict.items():
             driven = targetInfo[0]
             ctrl = driven.name().replace("_driven", "_ctl")
+            driven_ctl.append(targetInfo[1][0])
             for attr in ["invTx", "invTy", "invTz", "invRx", "invRy", "invRz"]:
                 pm.setAttr(driven + "." + attr, pm.getAttr(ctrl + "." + attr))
         for index in range(poseIndices):
@@ -1554,7 +1558,7 @@ def mirrorSetup(self):
             anim_utils.mirrorPose(flip=False, nodes=[driverControl])
             mrData = []
             for srcNode, dstValues in setupTargetInfo_dict.items():
-                mrData.extend(anim_utils.calculateMirrorDataRBF(srcNode,
+                mrData.extend(anim_utils.calculateMirrorData(srcNode,
                                                                 dstValues[0]))
             for entry in mrData:
                 anim_utils.applyMirror(nameSpace, entry)
@@ -1571,6 +1575,8 @@ def mirrorSetup(self):
         for mrRbfNode in mrRbfNodes:
             rbf_node.resetDrivenNodes(str(mrRbfNode))
         pm.select(cl=True)
+        self.reevalluateAllNodes()
+        attribute.reset_SRT(driven_ctl)
 
     def hideMenuBar(self, x, y):
         """rules to hide/show the menubar when hide is enabled

release/scripts/mgear/rigbits/rbf_manager_ui.py

@@ -73,6 +73,7 @@
 from mgear.core import pyqt
 import mgear.core.string as mString
 from mgear.core import anim_utils
+from mgear.core import attribute
 from mgear.vendor.Qt import QtWidgets, QtCore, QtCompat
 from maya.app.general.mayaMixin import MayaQWidgetDockableMixin
 
@@ -293,6 +294,7 @@ def show(dockable=True, newSceneCallBack=True, *args):
             pass
     RBF_UI = RBFManagerUI(parent=pyqt.maya_main_window(),
                           newSceneCallBack=newSceneCallBack)
+    RBF_UI.reevalluateAllNodes()
     RBF_UI.show(dockable=True)
     return RBF_UI
 
@@ -1624,9 +1626,11 @@ def mirrorSetup(self):
         driverControl = aRbfNode.getDriverControlAttr()
         driverControl = pm.PyNode(driverControl)
         # Sanity check: make sure mirror attributes are set up properly
+        driven_ctl = []
         for targetInfo in setupTargetInfo_dict.items():
             driven = targetInfo[0]
             ctrl = driven.name().replace("_driven", "_ctl")
+            driven_ctl.append(targetInfo[1][0])
             for attr in ["invTx", "invTy", "invTz", "invRx", "invRy", "invRz"]:
                 pm.setAttr(driven + "." + attr, pm.getAttr(ctrl + "." + attr))
         for index in range(poseIndices):
@@ -1635,7 +1639,7 @@ def mirrorSetup(self):
             anim_utils.mirrorPose(flip=False, nodes=[driverControl])
             mrData = []
             for srcNode, dstValues in setupTargetInfo_dict.items():
-                mrData.extend(anim_utils.calculateMirrorDataRBF(srcNode,
+                mrData.extend(anim_utils.calculateMirrorData(srcNode,
                                                              dstValues[0]))
             for entry in mrData:
                 anim_utils.applyMirror(nameSpace, entry)
@@ -1652,6 +1656,8 @@ def mirrorSetup(self):
         for mrRbfNode in mrRbfNodes:
             rbf_node.resetDrivenNodes(str(mrRbfNode))
         pm.select(cl=True)
+        self.reevalluateAllNodes()
+        attribute.reset_SRT(driven_ctl)
 
     def hideMenuBar(self, x, y):
         """rules to hide/show the menubar when hide is enabled