Qt: honor control characters in ScriptingTextBuffer::print #3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After some further discussion in Discord, I've decided I don't want to submit this PR as-is -- it fixes the bug, but the strategy for how to fix it is inelegant and leaves bugs pertaining to |
ahigerd
force-pushed
the
alh/fix-textbuffer-newlines
branch
from
f2bba1b
to
83064ef
Compare
ahigerd
changed the title
ahigerd
force-pushed
the
alh/fix-textbuffer-newlines
branch
from
83064ef
to
0ce43e6
Compare
|
Rewritten -- and added support for |
endrift
reviewed
Nov 23, 2024
| int lineWidth = m_dims.width(); | ||
|
|
||
| for (const QChar& ch : text) { | ||
| if (ch == '\t') { |
There was a problem hiding this comment.
Do we want to do this with a switch statement? (Can we do this with a switch statement?)
There was a problem hiding this comment.
It COULD be done with a switch statement but I'm not sure it would make the code look any better.
There was a problem hiding this comment.
Well... After refactoring to fix the performance issue, maybe it would help.
ahigerd
force-pushed
the
alh/fix-textbuffer-newlines
branch
2 times, most recently
from
058774e
to
10ec5b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR fixed line wrapping for strings with embedded newlines, but in the process it completely broke newline handling.
This PR makes sure that the cursor moves to the next block / a new block after each line.