Skip to content

Commit

Permalink
opt: mark FoldInEmpty and FoldNotInEmpty as essential
Browse files Browse the repository at this point in the history
These normalization rules are essential for costfuzz and
unoptimized-query-oracle tests until cockroachdb#88141 is fixed.

Release note: None
  • Loading branch information
mgartner committed Sep 19, 2022
1 parent 4af4359 commit 7dcc513
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pkg/sql/opt/xform/optimizer.go
Original file line number Diff line number Diff line change
Expand Up @@ -1001,6 +1001,9 @@ func (o *Optimizer) disableRulesRandom(probability float64) {
// Needed to make sure that dummy columns are pruned so that the
// database name is retrieved correctly.
int(opt.PruneScanCols),
// TODO(#88141): Needed until a bug in the vectorized engine is fixed.
int(opt.FoldInEmpty),
int(opt.FoldNotInEmpty),
)

var disabledRules RuleSet
Expand Down

0 comments on commit 7dcc513

Please sign in to comment.