Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling of merging restrictions with base in configuration #528

Merged

Conversation

mingyaulee
Copy link
Contributor

v2.1.954 has been a breaking change due to the merging of restrictions in 4539c1e.

As a result, properties with numeric restrictions were previously generated as string and now generated as numeric types (byte/ushort/uint/int/long/etc.). This configuration allows projects to update to the latest version gradually with the ability to opt-out from the new behaviour temporarily.

With the configuration, projects using the package can update to the latest version in 2 parts, one with only changes to comments and attributes, and after that with only changes in the generated property types.

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.08%. Comparing base (4120626) to head (fc1028a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
XmlSchemaClassGenerator/Generator.cs 0.00% 2 Missing ⚠️
XmlSchemaClassGenerator/ModelBuilder.cs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #528      +/-   ##
==========================================
- Coverage   94.17%   94.08%   -0.09%     
==========================================
  Files          21       21              
  Lines        3159     3164       +5     
  Branches      495      496       +1     
==========================================
+ Hits         2975     2977       +2     
- Misses        120      122       +2     
- Partials       64       65       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mganss mganss merged commit 9e2b96d into mganss:master Aug 30, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants