Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to have offsets in form field #46

Closed
stalker314314 opened this issue Apr 29, 2018 · 5 comments
Closed

Ability to have offsets in form field #46

stalker314314 opened this issue Apr 29, 2018 · 5 comments

Comments

@stalker314314
Copy link

Hi,
Besides just showing drop-down box with names of timezones, it would be nice to show them with offsets, in parenthesis maybe. It is usual practice on a lot of websites (example is from crowdin, but I think you are aware of what I am referring to)

slika

Maybe not as default behavior, but controllable over settings (not sure, just throwing ideas)
@mfogel
Copy link
Owner

mfogel commented Sep 15, 2018

Yeah, looks like a good idea. Pull requests happily entertained :) I would prefer this was first implemented as optional behavior, not default. If it's great and everyone loves it, we can later move it from optional to default.

@bernd-wechner
Copy link

Great idea but yes indeed should always be optional IMHO.

mfogel pushed a commit that referenced this issue Sep 17, 2019
@sm-m-1 @mfogel
RE: Issue #46 | Include GMT offset in timezone choices text (#49)
6b8bbc4 
* issue_46_implement_GMT_offset_in_timezones

* issue_46_implement_GMT_offset_in_timezones remove comment

* issue_46_implement_GMT_offset_in_timezones remove underscores from names.

* write tests and move function to utils. Probably makes more sense.

* add documentation.
@mfogel
Copy link
Owner

mfogel commented Sep 17, 2019 •
edited
Loading

This was merged into master in 6b8bbc4 and will be included in the next release. It is off by default.

@mfogel mfogel closed this as completed Sep 17, 2019
@drtpotter
Copy link

This feature doesn't appear to be in 4.0, would be great to see it there!

@mfogel
Copy link
Owner

mfogel commented Jun 13, 2021

@drtpotter it's available as an optional kwarg for the field, choices_display='WITH_GMT_OFFSET'. There's an example available of using this kwarg in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mfogel @stalker314314 @bernd-wechner @drtpotter