Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue#159 - Add parent_folder_uri parameter and creating folder in a subfolder #175

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

anjared
Copy link

@anjared anjared commented Oct 31, 2022

Using the code posted by @ivoryguard - I took it one small step further and made the added parameter optional with a default value of null.

The Vimeo API does now handle this property on the create folder request: https://developer.vimeo.com/api/reference/folders#create_project

Fixes #159

@anjared
Copy link
Author

anjared commented Nov 2, 2022

@mfilippov - just checking to see if you could merge this. Thanks.

@mfilippov
Copy link
Owner

@anjared Change looks good to me but please fix compilation.

@anjared
Copy link
Author

anjared commented Nov 2, 2022

@mfilippov - sorry about that. Fixed now.

@mfilippov mfilippov merged commit df6c47f into mfilippov:master Nov 2, 2022
@mfilippov
Copy link
Owner

@anjared Thank you for the contribution! Your PR available in 2.2.0

@anjared
Copy link
Author

anjared commented Nov 2, 2022

Confirmed this is now working after upgrading the production Nuget package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sub folder support
3 participants