Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new features and some minor changes #164

Merged
merged 11 commits into from
Jan 25, 2022

Conversation

karan12990
Copy link
Contributor

@mfilippov

Sorry for the delay.

I am creating new PR and closing PR.

In this PR below changes are included.

  • Allow user to fetch video by folder
  • allow user to delete thumbnail of video
  • Return picture base_link from pictures class
  • Fixed property key of picture class link to base_link

Also, i have reverted licence and README file. Please take a look

Thanks.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Owner

@mfilippov mfilippov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will check what is wrong with tests on this week.

@karan12990
Copy link
Contributor Author

@mfilippov

Did you get a chance to look into this ?

@mfilippov
Copy link
Owner

I checked tests locally all work ok. Looks like a CI issue.

@mfilippov mfilippov merged commit 02c1648 into mfilippov:master Jan 25, 2022
@mfilippov
Copy link
Owner

Thank you for your contribution!

@mfilippov
Copy link
Owner

@karan12990 Your PR available in v2.1.2 on nuget.org

@karan12990
Copy link
Contributor Author

@mfilippov

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants