Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Item hiding is completely broken. #2916

Closed
ghost opened this issue Jul 22, 2022 · 4 comments
Closed

[Bug]: Item hiding is completely broken. #2916

ghost opened this issue Jul 22, 2022 · 4 comments
Labels

Comments

@ghost
Copy link

ghost commented Jul 22, 2022

Steps to Reproduce the Bug

Three issues.
A - You can only ever hide one item. (Unless you add them manually in blacklist.cfg)
B - Hiding by wildcard does not work at all.
C - Hiding all items of a mod is completely gone.

Issue A: 1. Get into a world. 2. Bind Item Edit mode to a key (since it's unbound by default). 3. Press that key and hide multiple items using CTRL+Left Click.

Issue B: Same as above, but try hiding using CTRL+Right Click this time.

Issue C: Just check the keybinds menu.

Expected Behavior

Issue A: All items I hid are saved to blacklist.cfg.

Issue B: A wildcard is added to blacklist.cfg, instead of the singular item I clicked.

Issue C: Hiding by mod is available and working.

Actual Behavior

Issue A: If I quit and immediately enter the same world again, everything works perfectly. However, if you check the blacklist.cfg, only the first item I hid is in there.
If I fully quit Minecraft and join again, only that one item is hidden.

Issue B: It acts exactly as if I was using CTRL+Left Click instead, even showing up in the blacklist.cfg as the full item name instead of a wildcard.

Issue C: No option for it in the keybinds menu, yet it's still mentioned in the mod's web pages.

Mod Pack URL (Optional)

No response

Mod Pack Version (Optional)

No response

Extra Notes (Optional)

Was hiding entire mods removed? Are there plans to implement it again?

If these are all bugs indeed, would you mind sharing how the blacklist.cfg works?
For example, how wildcards are referenced, and how entire mods are referenced?
I tried the latter using simply "modname", then "modname:" and "modname:*", each in individual lines. Nothing worked.

(Thank you for porting to fabric, by the way. I'm actually using the forge version to generate the cfg files so I can copy them to fabric, lol)

latest.log

https://gist.github.com/ridaway/6d1610045d912bc39ecd29ce8be78dc8

@mezz mezz added the bug label Jul 26, 2022
@mezz
Copy link
Owner

mezz commented Jul 26, 2022

Thanks for the report!
This feature hasn't been used much, since CraftTweaker and KubeJS have become better solutions. You may want to use one of those as a workaround until this is fixed.
I see the report is from jei-1.19-forge-11.0.2.230, but are you experiencing this issue on Forge, Fabric, or both?

@ghost
Copy link
Author

ghost commented Jul 26, 2022

Fabric doesn't support it yet, the keybinds aren't implemented. I was using it on Forge so I could then copy the files to the Fabric version.

@ghost
Copy link

ghost commented Aug 12, 2022

I have the same issue as OP, and I'm also trying to use the feature the same way. Do you mind elaborating on how CraftTweaker and KubeJS could be use as alternatives? A quick glance at them and it seems they're really complicated. Also, since the blacklist file technically works still, do you mind answering this from OP?

For example, how wildcards are referenced, and how entire mods are referenced?
I tried the latter using simply "modname", then "modname:" and "modname:*", each in individual lines. Nothing worked.

@EccentricVamp
Copy link

I'm also experiencing this issue on Minecraft 1.18.2, Forge, JEI 9.7.2.259

@mezz mezz closed this as completed in 9d17753 Aug 28, 2024
mezz added a commit that referenced this issue Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants