MA0143 detects ref/out usages

meziantou · Dec 28, 2023 · 7944ccd · 7944ccd
1 parent 778141f
commit 7944ccd
Show file tree

Hide file tree

Showing 2 changed files with 106 additions and 0 deletions.
diff --git a/src/Meziantou.Analyzer/Rules/PrimaryConstructorParameterShouldBeReadOnlyAnalyzer.cs b/src/Meziantou.Analyzer/Rules/PrimaryConstructorParameterShouldBeReadOnlyAnalyzer.cs
@@ -40,9 +40,35 @@ public override void Initialize(AnalysisContext context)
             context.RegisterOperationAction(AnalyzerAssignment, OperationKind.DeconstructionAssignment);
             context.RegisterOperationAction(AnalyzerIncrementOrDecrement, OperationKind.Increment);
             context.RegisterOperationAction(AnalyzerIncrementOrDecrement, OperationKind.Decrement);
+            context.RegisterOperationAction(AnalyzerInitializer, OperationKind.VariableDeclarator);
+            context.RegisterOperationAction(AnalyzerArgument, OperationKind.Argument);
         });
     }
 
+    private void AnalyzerArgument(OperationAnalysisContext context)
+    {
+        var operation = (IArgumentOperation)context.Operation;
+        if (operation.Parameter is { RefKind: RefKind.Ref or RefKind.Out } && IsPrimaryConstructorParameter(operation.Value, context.CancellationToken))
+        {
+            context.ReportDiagnostic(Rule, operation.Value);
+        }
+    }
+
+    private void AnalyzerInitializer(OperationAnalysisContext context)
+    {
+        var operation = (IVariableDeclaratorOperation)context.Operation;
+        if (operation.Initializer is null)
+            return;
+
+        if (operation.Symbol.RefKind is RefKind.Ref or RefKind.Out)
+        {
+            if (IsPrimaryConstructorParameter(operation.Initializer.Value, context.CancellationToken))
+            {
+                context.ReportDiagnostic(Rule, operation.Initializer.Value);
+            }
+        }
+    }
+
     private void AnalyzerIncrementOrDecrement(OperationAnalysisContext context)
     {
         var operation = (IIncrementOrDecrementOperation)context.Operation;

diff --git a/...Meziantou.Analyzer.Test/Rules/PrimaryConstructorParameterShouldBeReadOnlyAnalyzerTests.cs b/...Meziantou.Analyzer.Test/Rules/PrimaryConstructorParameterShouldBeReadOnlyAnalyzerTests.cs
@@ -143,5 +143,85 @@ void A()
                 """)
               .ValidateAsync();
     }
+
+    [Fact]
+    public async Task AssignVariable()
+    {
+        await CreateProjectBuilder()
+              .WithSourceCode("""
+                class Test(string p)
+                {
+                    void A()
+                    {
+                        var a = p;
+                    }
+                }
+                """)
+              .ValidateAsync();
+    }
+
+    [Fact]
+    public async Task Argument()
+    {
+        await CreateProjectBuilder()
+              .WithSourceCode("""
+                class Test(string p)
+                {
+                    void A(string value)
+                    {
+                        A(p);
+                    }
+                }
+                """)
+              .ValidateAsync();
+    }
+
+    [Fact]
+    public async Task EditUsingRefVariable()
+    {
+        await CreateProjectBuilder()
+              .WithSourceCode("""
+                class Test(string p)
+                {
+                    void A()
+                    {
+                        ref var a = ref [|p|];
+                    }
+                }
+                """)
+              .ValidateAsync();
+    }
+
+    [Fact]
+    public async Task EditUsingRefParameter()
+    {
+        await CreateProjectBuilder()
+              .WithSourceCode("""
+                class Test(string p)
+                {
+                    void A(ref string a)
+                    {
+                        A(ref [|p|]);
+                    }
+                }
+                """)
+              .ValidateAsync();
+    }
+
+    [Fact]
+    public async Task EditUsingInParameter()
+    {
+        await CreateProjectBuilder()
+              .WithSourceCode("""
+                class Test(string p)
+                {
+                    void A(in string a)
+                    {
+                        A(in p);
+                    }
+                }
+                """)
+              .ValidateAsync();
+    }
 }
 #endif