Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seek #43

Closed
wants to merge 26 commits into from
Closed

Seek #43

wants to merge 26 commits into from

Commits on Jan 17, 2021

  1. wip

    got something working with seek table and fixed block sized flac
    cswank committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    234e5d1 View commit details
    Browse the repository at this point in the history
  2. Don't need readseeker receiver

    cswank committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    81242fa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e16fd49 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b4c1a69 View commit details
    Browse the repository at this point in the history
  5. sane-ish number of seek points

    cswank committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    de12b38 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2021

  1. support io.SeekEnd and io.SeekCurrent

    TODO: handle cases where sample is invalid:
    
    whence == io.SeekEnd && sample is not negative
    whence == io.SeekStart && sample is negative
    whence == io.SeekCurrent and sample + current sample < 0 or > stream.Info.NSamples
    cswank committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    f6950a1 View commit details
    Browse the repository at this point in the history
  2. hande seek error

    cswank committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    230217d View commit details
    Browse the repository at this point in the history
  3. whence error

    cswank committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    c28c6a4 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2021

  1. CR changes

    cswank committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    38f6396 View commit details
    Browse the repository at this point in the history
  2. parse seekTable in flac.Parse

    cswank committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    e05b8a8 View commit details
    Browse the repository at this point in the history
  3. use bufio.Reader in flac.Parse

    cswank committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    ef305be View commit details
    Browse the repository at this point in the history
  4. more CR changes

    cswank committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    df42987 View commit details
    Browse the repository at this point in the history
  5. fix searchFromEnd

    cswank committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    9c8b366 View commit details
    Browse the repository at this point in the history
  6. fix comments

    cswank committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    9fe78ac View commit details
    Browse the repository at this point in the history
  7. remote commented out code

    cswank committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    1fb180a View commit details
    Browse the repository at this point in the history
  8. remove 'seems'

    cswank committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    dcd1fe4 View commit details
    Browse the repository at this point in the history
  9. fix comment

    cswank committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    ad8e6e7 View commit details
    Browse the repository at this point in the history
  10. comment

    cswank committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    c28ed01 View commit details
    Browse the repository at this point in the history
  11. reword comment

    cswank committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    190d6e3 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. I won't be offended if you ask me to get rid of this commit!

    This commit changes the way Stream is initialized quite a bit
    and maybe it is less readable?  I personally think it's more readable
    because I really like the variadic argument pattern so I've used it
    quite a bit.
    
    I think it addresses some of the concerns:
    
    1:  Use *bufio.Reader as the default in order to match the current
        behaivor by calling
    
        stream, err = flac.New(r)
    
    2:  Make Seek explicitly optional by calling:
    
        stream, err = flac.New(r, flac.EnableSeek)
    cswank committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    0457be3 View commit details
    Browse the repository at this point in the history
  2. rename Option func

    cswank committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    17be08e View commit details
    Browse the repository at this point in the history
  3. wip

    cswank committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    3a3d69e View commit details
    Browse the repository at this point in the history
  4. add skip test

    cswank committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    58790bb View commit details
    Browse the repository at this point in the history
  5. more seeks in seek test

    cswank committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    9433f10 View commit details
    Browse the repository at this point in the history
  6. test decode all the test files

    cswank committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    61be5f2 View commit details
    Browse the repository at this point in the history
  7. close test stream

    cswank committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    266a720 View commit details
    Browse the repository at this point in the history