-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seek #43
Closed
Closed
Seek #43
Commits on Jan 17, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 234e5d1 - Browse repository at this point
Copy the full SHA 234e5d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 81242fa - Browse repository at this point
Copy the full SHA 81242faView commit details -
Configuration menu - View commit details
-
Copy full SHA for e16fd49 - Browse repository at this point
Copy the full SHA e16fd49View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4c1a69 - Browse repository at this point
Copy the full SHA b4c1a69View commit details -
Configuration menu - View commit details
-
Copy full SHA for de12b38 - Browse repository at this point
Copy the full SHA de12b38View commit details
Commits on Jan 18, 2021
-
support io.SeekEnd and io.SeekCurrent
TODO: handle cases where sample is invalid: whence == io.SeekEnd && sample is not negative whence == io.SeekStart && sample is negative whence == io.SeekCurrent and sample + current sample < 0 or > stream.Info.NSamples
Configuration menu - View commit details
-
Copy full SHA for f6950a1 - Browse repository at this point
Copy the full SHA f6950a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 230217d - Browse repository at this point
Copy the full SHA 230217dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c28c6a4 - Browse repository at this point
Copy the full SHA c28c6a4View commit details
Commits on Jan 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 38f6396 - Browse repository at this point
Copy the full SHA 38f6396View commit details -
Configuration menu - View commit details
-
Copy full SHA for e05b8a8 - Browse repository at this point
Copy the full SHA e05b8a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef305be - Browse repository at this point
Copy the full SHA ef305beView commit details -
Configuration menu - View commit details
-
Copy full SHA for df42987 - Browse repository at this point
Copy the full SHA df42987View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c8b366 - Browse repository at this point
Copy the full SHA 9c8b366View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fe78ac - Browse repository at this point
Copy the full SHA 9fe78acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fb180a - Browse repository at this point
Copy the full SHA 1fb180aView commit details -
Configuration menu - View commit details
-
Copy full SHA for dcd1fe4 - Browse repository at this point
Copy the full SHA dcd1fe4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad8e6e7 - Browse repository at this point
Copy the full SHA ad8e6e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c28ed01 - Browse repository at this point
Copy the full SHA c28ed01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 190d6e3 - Browse repository at this point
Copy the full SHA 190d6e3View commit details
Commits on Jan 20, 2021
-
I won't be offended if you ask me to get rid of this commit!
This commit changes the way Stream is initialized quite a bit and maybe it is less readable? I personally think it's more readable because I really like the variadic argument pattern so I've used it quite a bit. I think it addresses some of the concerns: 1: Use *bufio.Reader as the default in order to match the current behaivor by calling stream, err = flac.New(r) 2: Make Seek explicitly optional by calling: stream, err = flac.New(r, flac.EnableSeek)
Configuration menu - View commit details
-
Copy full SHA for 0457be3 - Browse repository at this point
Copy the full SHA 0457be3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17be08e - Browse repository at this point
Copy the full SHA 17be08eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a3d69e - Browse repository at this point
Copy the full SHA 3a3d69eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 58790bb - Browse repository at this point
Copy the full SHA 58790bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9433f10 - Browse repository at this point
Copy the full SHA 9433f10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61be5f2 - Browse repository at this point
Copy the full SHA 61be5f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 266a720 - Browse repository at this point
Copy the full SHA 266a720View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.