Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundler 1.14 load of native gem #297

Closed
bergholdt opened this issue Jan 21, 2017 · 4 comments
Closed

Bundler 1.14 load of native gem #297

bergholdt opened this issue Jan 21, 2017 · 4 comments

Comments

@bergholdt
Copy link

I have new builds failing on travis because of new bundler 1.14 released 20. jan.

This bundler version has a new way of loading native gems so our JRuby build will fail.
https://travis-ci.org/bergholdt/metric_fu/builds/193916594

I can see issues on bundler repo rubygems/bundler#5337 related to this

A work a round is to force 1.13.7 on travis
bergholdt/metric_fu@8a9965b...04e1917
https://travis-ci.org/bergholdt/metric_fu/builds/194016131

@jkeam
Copy link
Member

jkeam commented Jan 22, 2017

I'm worried about people running JRuby and Bundler 1.14. Is there anyway we could help them? Or maybe just put a note in the README so users know that this is the workaround until we can figure out a solution?

@bergholdt
Copy link
Author

Agree that we should make it possible for users to use whatever bundler version they need.

But I do hope that it's an error in bundler and they help us solve this 😊

This issue rubygems/bundler#5340 has a PR that looks like to fix it.

Think we should await this before making more gemfile rules.

@bf4
Copy link
Member

bf4 commented Jan 22, 2017

@bergholdt freezing the bundler version in travis seems like what the end user would do until the bundler issue is resolved. It's not uncommon to do that in CI. I'm 👍 and leave a comment referencing this PR, say 'remove when #297 resolved', or something like that.

@bergholdt
Copy link
Author

Builds now pass on bundler 1.14.3 on both Travis and AppVeyor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants